Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip_axes parameter to phasor_calibrate function #42

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

bruno-pannunzio
Copy link
Contributor

Description

This PR adds the skip_axes parameter to phasor_calibrate function for the center calculation of reference coordinates.
...

Release note

Summarize the changes in the code block below to be included in the
release notes:

Add `skip_axes` parameter to `phasor_calibrate`

Checklist

  • The pull request title, summary, and description are concise.
  • Related issues are linked in the description.
  • New dependencies are explained.
  • The source code and documentation can be distributed under the MIT license.
  • The source code adheres to code standards.
  • New classes, functions, and features are thoroughly tested.
  • New, user-facing classes, functions, and features are documented.
  • New features are covered in tutorials.
  • No files other than source code, documentation, and project settings are added to the repository.

@bruno-pannunzio bruno-pannunzio added the enhancement New feature or request label Mar 7, 2024
@bruno-pannunzio bruno-pannunzio requested a review from cgohlke March 7, 2024 17:19
@bruno-pannunzio bruno-pannunzio self-assigned this Mar 7, 2024
@bruno-pannunzio
Copy link
Contributor Author

I added the skip_axes to phasor_calibrate but this parameter, as some other parameters passed to phasor_from_lifetime are not thoroughly tested. We should think of improving this in the near future.

@bruno-pannunzio bruno-pannunzio merged commit c2f1262 into phasorpy:main Mar 7, 2024
13 checks passed
@bruno-pannunzio bruno-pannunzio deleted the calibration-function branch March 8, 2024 14:08
@cgohlke cgohlke changed the title Add skip_axes to phasor_calibrate Add skip_axes parameter to phasor_calibrate function Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants