Fix contour offsets #40
Conversation
There was a problem hiding this comment.
@cgohlke this seems ok. Although it is not strictly from this PR, I think that testing all plots as it is now can be a little bit tedius when you have to run the pytest multiple times, since each time, all the plots are showed one by one and you have to manually close all windows one at a time, which can be a little bit time consuming when having to run it several times as I had to do it for the previous PR. Maybe we can think of an alternative to test the plots without having to manually see one by one an close them, but for now that we are testing a lot it can be a good idea to avoid this tests and maybe visually check the tutorials to see if the plots are correct?
Yes, we discussed this in the last meeting. When the plotting functionality stabilizes we will switch to comparing against ground truth images using the matplotlib testing API. I think it is still too early. Interactive mode is off by default during testing. Does that switch not work on your setup? I manually enabled it when implementing the tests. Pytest and VSCode, for example, allow to select which tests to run. There is no need to always run all tests. |
|
You are right, I forgot you can select which tests to run instead of all, so it's a good idea to leave it as it is and then review it when we can implement the matplotlib testing API. I didn't modified from the default, so in my setup by default it enabled the interactive mode, I will look more into this in my mac. |
Yes, please share a fix if you find one. |
Description
Fix contour coordinates are offset by half a pixel in each direction.
Release note
Summarize the changes in the code block below to be included in the
release notes:
Checklist