Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add read functions for PTU, FBD, and FLIF files #25

Merged
merged 3 commits into from
Jan 6, 2024
Merged

Add read functions for PTU, FBD, and FLIF files #25

merged 3 commits into from
Jan 6, 2024

Conversation

cgohlke
Copy link
Member

@cgohlke cgohlke commented Jan 4, 2024 •
edited
Loading

Description

This PR adds read functions for PTU, FBD, and FLIF files to the phasorpy.io module. It also fixes the IFLI spectral axes code and makes read_sdt accept SDT FCS data files.

The ptufile library is added as an optional dependency required for reading PTU files.

Partly addresses issue #10.

Release note

Summarize the changes in the code block below to be included in the
release notes:

Add read functions for PTU, FBD, and FLIF files

Checklist

  • The pull request title, summary, and description are concise.
  • Related issues are linked in the description.
  • New dependencies are explained.
  • The source code and documentation can be distributed under the MIT license.
  • The source code adheres to code standards.
  • New classes, functions, and features are thoroughly tested.
  • New, user-facing classes, functions, and features are documented.
  • New features are covered in tutorials.
  • No files other than source code, documentation, and project settings are added to the repository.

@cgohlke cgohlke self-assigned this Jan 4, 2024
@cgohlke cgohlke added the enhancement New feature or request label Jan 4, 2024
bruno-pannunzio
bruno-pannunzio approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@bruno-pannunzio bruno-pannunzio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this functions Christoph. I tested read_ptu and read_fbd and they work perfectly. I added some comments because I didn't understand a couple of arguments and also gave some feedback on implementing something for when reading all files that can be very useful so that it can be possible to trim the dimensions.

src/phasorpy/io.py Show resolved Hide resolved
src/phasorpy/io.py Show resolved Hide resolved
src/phasorpy/io.py Show resolved Hide resolved
@cgohlke cgohlke merged commit 6614090 into phasorpy:main Jan 6, 2024
11 checks passed
@cgohlke cgohlke deleted the io branch January 6, 2024 05:16
@cgohlke cgohlke mentioned this pull request Jan 14, 2024
Closed
bruno-pannunzio pushed a commit to bruno-pannunzio/phasorpy that referenced this pull request Jan 16, 2024
@cgohlke @bruno-foliume
Add read functions for PTU, FBD, and FLIF files (phasorpy#25)
dba25bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-pannunzio bruno-pannunzio bruno-pannunzio approved these changes

@schutyb schutyb Awaiting requested review from schutyb

@lmalacrida lmalacrida Awaiting requested review from lmalacrida

Assignees

@cgohlke cgohlke

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgohlke @bruno-pannunzio