adds get_fixed_examples to TemplateIterator #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pesser
requested changes
May 12, 2020
There was a problem hiding this comment.
This will be a great feature, but
- it would be great if one can specify which dataset to take the examples from, eg
trainorvalidation. - I think the interface would be more consistent if the function just returns a batch exactly the way the step_op receives the batch instead of having to specify the keys. In addition it would be great if we can make sure that the behavior is exactly that of the dataloader - I think this is readily achieved by using
iterators.batches.deep_lod2dol
| ) | ||
| fixed_examples = {} | ||
| for n in names: | ||
| fixed_examples_n = [self.dataset[i][n] for i in fixed_example_indices] |
There was a problem hiding this comment.
this is unnecessarily inefficient. Make sure get_example is called only once for each index, eg fixed_examples = [self.dataset[i] for i in fixed_example_indices] outside of the for n in names loop.
| "stickman": batch of self.dset[i]["stickman"] with fixed i | ||
| } | ||
|
|
||
| TODO: document usage somewhere |
There was a problem hiding this comment.
my best guess: this will never happen once that todo is committed. I suggest doing the todos immediately or removing the todo comments
Done |
Done |
pesser
approved these changes
Jul 17, 2020
|
Great! Now I can finally get rid of the copy & pasted code in my iterators :) 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.