Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Table: add column sorting #2450

Merged
merged 2 commits into from
Dec 2, 2024
Merged

[ENHANCEMENT] Table: add column sorting #2450

merged 2 commits into from
Dec 2, 2024

Conversation

Gladorme
Copy link
Member

@Gladorme Gladorme commented Dec 2, 2024

Description

Looks like I forgot to implem the sorting logic when a column is sortable...

Screenshots

image
image

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • Visual tests are stable and unlikely to be flaky.
    See Storybook
    and e2e docs for more details. Common issues
    include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

@Gladorme
[ENHANCEMENT] Table: add column sorting
8ad54ce 
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
@Gladorme Gladorme marked this pull request as ready for review December 2, 2024 14:21
@Gladorme
remove weird imports
9687e08 
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
AntoineThebaud
AntoineThebaud approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@AntoineThebaud AntoineThebaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"oops" too, as the reviewer of the PR that should have implemented that 🤡

@Gladorme Gladorme added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit e61a1ae Dec 2, 2024
18 checks passed
@Gladorme Gladorme deleted the gladorme/table-sort branch December 2, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineThebaud AntoineThebaud AntoineThebaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gladorme @AntoineThebaud