Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Migration: Fix table migration fail when excludeByName is not present in transformation="organize" #2332

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

7840vz
Copy link
Contributor

@7840vz 7840vz commented Oct 11, 2024

Description

Fix table migration fail when excludeByName is not present in transformation="organize".
Note: Logic is currently disable altogther.

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

…n.id == "organize"

Signed-off-by: 7840vz <7840vz@users.noreply.github.com>
@7840vz 7840vz changed the title [BUGFIX] Fix table migration fail when excludeByName is not present in transformation="organize" [BUGFIX] Migration: Fix table migration fail when excludeByName is not present in transformation="organize" Oct 11, 2024
Copy link
Contributor

@AntoineThebaud AntoineThebaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this (future) fix! Too bad we have to disable this whole part for now :l

@AntoineThebaud AntoineThebaud merged commit 06b2d60 into perses:main Oct 13, 2024
17 of 18 checks passed
ibakshay pushed a commit to ibakshay/perses that referenced this pull request Oct 21, 2024
…n.id == "organize" (perses#2332)

Signed-off-by: 7840vz <7840vz@users.noreply.github.com>
Signed-off-by: Akshay Iyyadurai Balasundaram <akshay.iyyadurai.balasundaram@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants