Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] move config to pkg so its available publicly #1636

Merged
merged 1 commit into from
Dec 11, 2023
Merged

[ENHANCEMENT] move config to pkg so its available publicly #1636

merged 1 commit into from
Dec 11, 2023

Conversation

jgbernalp
Copy link
Contributor

@jgbernalp jgbernalp commented Dec 11, 2023 •
edited
Loading

Description

In order to use the same types for Perses configuration in the perses operator, they should be available publicly

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

@jgbernalp jgbernalp requested a review from Nexucis December 11, 2023 09:13
@Nexucis
Copy link
Member

Nexucis commented Dec 11, 2023

I think it would be better if the package is under the /api folder : pkg/api/config. (because it's the API's config)

Looks good excepting that !

@jgbernalp
[ENHANCEMENT] move config to pkg so its available publicly
24f99c8 
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@jgbernalp jgbernalp force-pushed the make-config-available-publicly branch from a897e0e to 24f99c8 Compare December 11, 2023 13:19
Nexucis
Nexucis approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Nexucis Nexucis added this pull request to the merge queue Dec 11, 2023
Merged via the queue into perses:main with commit 646c23b Dec 11, 2023
@Nexucis Nexucis mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nexucis Nexucis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgbernalp @Nexucis