Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally import ssh modules #42

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conditionally import ssh modules #42

merged 1 commit into from
Jul 19, 2022

Conversation

superrnovae
Copy link
Member

@superrnovae superrnovae commented Jul 18, 2022 •
edited
Loading

Should be closing #41

But needs testing first

@itsnebulalol
Copy link
Member

itsnebulalol commented Jul 18, 2022 •
edited
Loading

@FreQRiDeR

@itsnebulalol itsnebulalol added the bugfix Fix for a bug label Jul 18, 2022
@itsnebulalol itsnebulalol linked an issue Jul 18, 2022 that may be closed by this pull request
Bypass install, requirements, when run on ios? #41
Closed
@superrnovae
Copy link
Member Author

superrnovae commented Jul 18, 2022 •
edited
Loading

I have no idea how to conditionally check in requirements.txt. That would require to have a setup.py instead, where we could check for ios, linux, macos and install dependencies respectively.

Just tested on my iPad, and it doesn't complain about imports. The compiler issue has nothing to do with this script, rather with one of the dependencies, that will always get pulled in, whether we require it or not. It needs gcc or clang compiler installed. And also libpython-dev. And an exported CC variable pointing to one of the compilers and c headers.

@FreQRiDeR
Copy link

FreQRiDeR commented Jul 18, 2022 •
edited
Loading

Ok, works on ios now. Still prompts for install but hitting ‘y’ just finishes with prompt to install deb from output, which is perfect :)

@superrnovae
Copy link
Member Author

superrnovae commented Jul 18, 2022 •
edited
Loading

@itsnebulalol you can merge this. Will still have to figure out how to conditionally install dependencies.

@itsnebulalol itsnebulalol merged commit 72710b5 into permasigner:main Jul 19, 2022
@superrnovae superrnovae deleted the ios branch July 19, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix Fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bypass install, requirements, when run on ios?
3 participants
@superrnovae @itsnebulalol @FreQRiDeR