Symbols for each column #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I crosschecked the symbols with a purple pen and it seems like kind match column for all columns except column E which contains both kind E and D. I changed from all symbols to what I hope are the correct symbols for each column. There was an issue with svg-control-descriptions. Symbol "bend" was assigned to wrong kind in lang.json.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
perliedman
approved these changes
Dec 28, 2024
|
Nice, looks good! The issue with column F is noted in #9, I guess just making some kind of input field will solve it, but the data model also has to be extended to hold the value. |
perliedman
added a commit
that referenced
this pull request
Dec 28, 2024
Fixes issue where "bend" symbol appears in the wrong column, see discussion in #27.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I crosschecked the symbols with a purple pen and it seems like kind match column for all columns except column E which contains both kind E and D. I changed from all symbols to what I hope are the correct symbols for each column. "Object size" in column F is missing. I don't know how to handle that issue.
There was an issue with svg-control-descriptions. Symbol "bend" was assigned to wrong kind in lang.json.