Bugfix and paper sizes #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fix: Single clicks are not allowed because the function requires extent to work.
Added that the print area turns red if it is drawn larger than the paper size and also added the paper size to be visible on the map.
Added information about the area on paper. English term?
Bug fix: Set landscape to false.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
perliedman
approved these changes
Dec 26, 2024
|
Thanks, looks good! I made some minor tweaks, hope you don't mind! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix (ppen.js): Fixed issue with paper orientation when importing a Purple Pen file. When importing a Purple Pen file the orientation is incorrectly set to landscape (true). Landscape is not used by O-scout based on my findings. I changed the landscape setting to false.
Bugfix (objects.tsx): Fixed error message when adding a description with a single click. The function mapExtentToDescriptionLocations requires an extent, which is given by dragging an area while holding the left mouse button. I added an if-statement to check if the extent array exists. Otherwise an alert is triggered. The alert should eventually be replaced with a better solution.
Added information about paper size in relation to the print area in course settings (CourseOptions.js).
Added paper size to the map when changing the print area. It works on map with scale 1:15 000 but won't work with other map scales. Also modified the stroke around the print area to turn red when the print area exceeds the paper size (PrintArea.js).