Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Fix JSON header error by depending on nlohmann_json #70

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

emminizer
Copy link
Contributor

The tests include rocky/json.h, which in turn includes nlohmann/json.hpp. This is a private depedency of Rocky, so this include statement is not transitive. It fails to build. vcpkg builds do not see this because the vcpkg install directory is part of the include path, and this file is under it.

One solution is to make the JSON dependency public in Rocky, but header docs strongly suggest this is not the right path. A better path is to make the test add in the JSON dependency.

The find_package is required because the library is scoped to the src/rocky/ directory.

@gwaldron gwaldron merged commit 7473037 into pelicanmapping:main Jan 14, 2025
@emminizer emminizer deleted the fix-tests-json branch January 14, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants