download: suppress progress indicator for aws s3 cp command #487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in pelias/docker#266 the
aws s3 cp
command outputs regular progress information tostdout
.since we're using
child_process.exec
thestdout
is buffered until the process exits, if the buffer (1MB by default) fills up then an error occurs.we're not using the return value of
child_process.exec
(from what I could tell), so adding --only-show-errors suppresses it, while also not having to worry about conflicting/duplicate--no-progress
flags provided by the user.if we would like to return regular status reports of the file as it downloads then we would need to change
child_process.exec
tochild_process.spawn
and refactor accordingly, the latter allows customisation of thestdio
config forstdout
whereas the former does not.resolves pelias/docker#266