Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download: suppress progress indicator for aws s3 cp command #487

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

missinglink
Copy link
Member

@missinglink missinglink commented Sep 8, 2021

as discussed in pelias/docker#266 the aws s3 cp command outputs regular progress information to stdout.

since we're using child_process.exec the stdout is buffered until the process exits, if the buffer (1MB by default) fills up then an error occurs.

we're not using the return value of child_process.exec (from what I could tell), so adding --only-show-errors suppresses it, while also not having to worry about conflicting/duplicate --no-progress flags provided by the user.

if we would like to return regular status reports of the file as it downloads then we would need to change child_process.exec to child_process.spawn and refactor accordingly, the latter allows customisation of the stdio config for stdout whereas the former does not.

resolves pelias/docker#266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download OpenAddresses information via S3 fails due to buffer size
1 participant