Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/s3: add legacy flag for backward compatibility with ListObject #407

Merged
merged 3 commits into from
Apr 5, 2022

Conversation

greenpau
Copy link
Contributor

@greenpau greenpau commented Feb 8, 2022

storage/s3: add legacy flag for backward compatibility with ListObject

Signed-off-by: Paul Greenberg greenpau@outlook.com

@greenpau greenpau requested a review from a team as a code owner February 8, 2022 22:12
@greenpau greenpau requested review from aykutfarsak and sonmezonur and removed request for a team February 8, 2022 22:12
Signed-off-by: Paul Greenberg <greenpau@outlook.com>
@dmbyte
Copy link

dmbyte commented Mar 8, 2022

This solves issue 405. #405

Copy link
Member

@sonmezonur sonmezonur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greenpau Thanks for your contribution! Could you please update CHANGELOG?

command/app.go Outdated Show resolved Hide resolved
@greenpau
Copy link
Contributor Author

Could you please update CHANGELOG?

@sonmezonur , done! Added new entry.

@greenpau
Copy link
Contributor Author

greenpau commented Apr 4, 2022

@aykutfarsak, please review this change.

Copy link
Contributor

@aykutfarsak aykutfarsak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greenpau
Copy link
Contributor Author

greenpau commented Apr 4, 2022

LGTM

@aykutfarsak , thank you! Does it merge automatically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants