Location of credentials for accessing Google Cloud #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added note on location of credentials used when accessing Google Cloud
pjgo
requested review from
aykutfarsak and
seruman
and removed request for
a team
seruman
reviewed
Nov 7, 2021
|
@pjgo ping |
Co-authored-by: Selman Kayrancioglu <seruman@users.noreply.github.com>
|
Selman,
Below is a screen shot of my response to the previous comments:
* I agreed about adding this only to the Google Cloud Storage support section
* I asked whether this link is what you had in mind: https://cloud.google.com/storage/docs/authentication/hmackeys
Did I not send my response since it says "Pending"?
Thanks!
…On Mon, Apr 11, 2022 at 4:09 AM, Selman Kayrancioglu < ***@***.*** > wrote:
***@***.**** commented on this pull request.
In README. md (
#377 (comment) ) :
> @@ -429,6 +431,8 @@ or an alternative with environment variable
all
variants will return your GCS buckets.
+`s5cmd` reads `.aws/credentials`
to access Google Cloud Storage. Populate the `aws_access_key_ID` and
`aws_secret_access_key` fields in `.aws/credentials` with an HMAC key
created using the Google Cloud console or `gsutil`.
>
>
> #377 (comment) (
> #377 (comment) ) If there's
> an official documentation from GCS a link would be nice.
>
>
@ pjgo ( https://github.com/pjgo ) I would prefer reference to an official
documentation opposed to this and look like the sentence is duplicated in
both section.
I think there should be a reference to the GCS documentation only in GCS
section. If not we might as well just close this as GCS is no different
than the other S3 compatible services from s5cmd 's point of view.
—
Reply to this email directly, view it on GitHub (
#377 (comment) ) , or unsubscribe
(
https://github.com/notifications/unsubscribe-auth/AA45FXRWYKZ64JSM4OTBKZ3VEQB7LANCNFSM5HKBD2TQ
).
You are receiving this because you were mentioned. Message ID: <peak/s5cmd/pull/377/review/937834241
@ github. com>
|
|
I'm not able to see your responses. I think you started a code review instead of commenting directly, that might be the reason it says 'Pending'.
Yes, this seems fine. |
Added note on location of credentials used when accessing Google Cloud
|
@seruman I made the changes. Would you mind checking whether I did them correctly? Thanks
…On Mon, Apr 11 2022 at 6:39 AM, Selman Kayrancioglu < ***@***.*** > wrote:
@pjgo ( https://github.com/pjgo )
I'm not able to see your responses. I think you started a code review
instead of commenting directly, that might be the reason it says
'Pending'.
>
>
> * I asked whether this link is what you had in mind: cloud.google.com/storage/docs/authentication/hmackeys
> ( https://cloud.google.com/storage/docs/authentication/hmackeys )
>
>
>
Yes, this seems fine.
—
Reply to this email directly, view it on GitHub (
#377 (comment) ) , or unsubscribe
(
https://github.com/notifications/unsubscribe-auth/AA45FXQRZT5GVXW7YOVWRV3VEQTRVANCNFSM5HKBD2TQ
).
You are receiving this because you were mentioned. Message ID: <peak/s5cmd/pull/377/c1095065840
@ github. com>
|
fedorov
reviewed
Apr 16, 2022
| @@ -429,6 +430,8 @@ or an alternative with environment variable | |||
|
|
|||
| all variants will return your GCS buckets. | |||
|
|
|||
| `s5cmd` reads `.aws/credentials` to access Google Cloud Storage. Populate the `aws_access_key_id` and `aws_secret_access_key` fields in `.aws/credentials` with an HMAC key created using this [procedure](https://cloud.google.com/storage/docs/authentication/managing-hmackeys#create). | |||
There was a problem hiding this comment.
It might be helpful to point to an example of .aws/credentials, perhaps it is https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-files.html ? This may be obvious for AWS users, but as a someone coming from GCP, I have no idea what that file should look like.
There was a problem hiding this comment.
Also, the link mentioned above specifies key and secret without quotes. For me, until I added quotes, I was getting a parsing error.
There was a problem hiding this comment.
As AWS SDK has multiple credentials providers, I think we might add a link to AWS Go SDK's documentation to the https://github.com/peak/s5cmd#specifying-credentials section in a separate PR.
aykutfarsak
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not figure out whether
s5cmdwas reading credentials from.aws/credentials,.boto, or some other location when accessing Google Cloud. Moreover, Google Cloud provides several options for providing keys. I figured out through trial and error that I needed to generate HMAC keys using the Google Cloud console orgsutiland entering them into.aws/credentials.