command/sync: update default strategy, update tests #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename Strategy to SyncStrategy * Update SizeAndModificationStrategy to match awscli's SizeAndLastModifiedSync
* and simplify file name differences between source and destination
seruman
requested review from
aykutfarsak and
sonmezonur
and removed request for
a team
aykutfarsak
suggested changes
Sep 30, 2021
aykutfarsak
reviewed
Sep 30, 2021
command/sync_strategy.go
Outdated
| // time: src <= dst size: src == dst should sync: no | ||
| type SizeAndModificationStrategy struct{} | ||
|
|
||
| func (sm *SizeAndModificationStrategy) Compare(srcObj, dstObj *storage.Object) error { |
There was a problem hiding this comment.
On my first read of the code, I think that if Compare() returns nil, it means "these files are same, no need to sync". But it works just the opposite. Maybe we could consider renaming it or working the other way around.
There was a problem hiding this comment.
Agree, I've renamed it to ShouldSync.
Co-authored-by: Aykut Farsak <aykutfarsak@gmail.com>
igungor
reviewed
Sep 30, 2021
Co-authored-by: H. İbrahim Güngör <igungor@gmail.com>
Co-authored-by: H. İbrahim Güngör <igungor@gmail.com>
igungor
reviewed
Oct 1, 2021
igungor
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a summary of changes;
SizeAndModificationStrategy) to matchawscli's default strategy (SizeAndLastModifiedSync).synctests by mocking time to control remote object's upload time.gofakes3server.go fmtwanted to update build tags;