-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
command/cp: add cross-region transfer support #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should add multiple e2e tests
@fbarotov Hey ✋ Sorry for the late feedback. I personally found this approach better than #209 because of 2 reasons:
I think it is quite negligible since we make this call once and use the cached session afterward.
What do you think? Dou you want to work on this PR and resolve conflicts before we conclude which implementation is better? 😸 |
Hi @sonmezonur 🖐 Thanks a lot for the feedback. Awesome, I also ran your program on my laptop and got the following results:
indeed, as you mentioned they are negligible. Yes, the approach in this pr is more readable in my opinion as we would be having more loose coupling between session logic and operations logic. Let me try to resolve the conflicts :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pursuing this.
Resolves #155