Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pdm update -u fails when a depenendcy group contains a dependency group include #3336

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

frostming
Copy link
Collaborator

Fixes #3333

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

…ncy group include

Fixes #3333

Signed-off-by: Frost Ming <me@frostming.com>
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.37%. Comparing base (a7ac964) to head (95b7ce9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/pdm/project/core.py 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3336      +/-   ##
==========================================
- Coverage   85.39%   85.37%   -0.02%     
==========================================
  Files         112      112              
  Lines       11440    11443       +3     
  Branches     2497     2501       +4     
==========================================
+ Hits         9769     9770       +1     
- Misses       1141     1142       +1     
- Partials      530      531       +1     
Flag Coverage Δ
unittests 85.17% <94.11%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit 56e4943 into main Dec 6, 2024
21 checks passed
@frostming frostming deleted the frostming/issue3333 branch December 6, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdm update -u fails when a depenendcy group contains a dependency group include
1 participant