Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Question - git dependencies pinned to a specific revision #933

Closed
usrbinsam opened this issue Feb 23, 2022 · 0 comments
Closed

Feature/Question - git dependencies pinned to a specific revision #933

usrbinsam opened this issue Feb 23, 2022 · 0 comments
Labels
⭐ enhancement Improvements for existing features

Comments

@usrbinsam
Copy link

usrbinsam commented Feb 23, 2022

Is your feature request related to a problem? Please describe.

When adding a dependency from a (private) Git repository, pdm.lock records the commit revision hash. Yet, when installing the dependency, in another project, PDM always pulls in HEAD, regardless of the set revision hash.

Apologies in advance if this is really an underlying problem with pip and not PDM, or if there is a smarter way to go about this, maybe someone can point me in a better direction.

Describe the solution you'd like

Wouldn't it be desirable to have PDM/pip git checkout the revision recorded in pdm.lock whenever the dependency is installed, and then only pull in HEAD when pdm update is called?

Edit: #488 (comment) this comment looks like this is the right way to do what I'm looking for rather than through pdm.lock.

@usrbinsam usrbinsam added the ⭐ enhancement Improvements for existing features label Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ enhancement Improvements for existing features
Projects
None yet
Development

No branches or pull requests

1 participant