-
-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Exclude packaging 22.0
to avoid breakage
#1568
Conversation
Codecov ReportBase: 85.33% // Head: 85.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1568 +/- ##
==========================================
+ Coverage 85.33% 85.38% +0.04%
==========================================
Files 91 91
Lines 8068 8068
Branches 1911 1911
==========================================
+ Hits 6885 6889 +4
+ Misses 795 791 -4
Partials 388 388
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hi there, won't this happen again if packaging releases another version? |
so you don't want to pull in any future updates? i hope you are clear what the issue is here. we only exclude versions that are known to be buggy, removing the old behavior isn't a bug but a feature. |
I might not have the full picture of the issue and I'd indeed like future updates. I simply asked to understand if we could face the same issue when, say, packaging 22.1 is released. Honest questions, no intention to debate. Thanks a lot for your support! |
Locally, you probably have a single installation of PDM. In that case you could simply restrict its pipx inject pdm 'packaging!=22.0,!=22.1' In CI, you'll need to add an instruction to your steps/workflow to restrict it as well, until, again, PDM excludes or supports it. |
We have recently adopted pdm as our standard package manager and we have many installations in Python services, libraries and also environments such as JupyterLab or Databricks. This is why the issue created a bit of havoc everywhere when an old, unused version of pyzqm couldn't be parsed as candidate. Thanks! moving to the other conversation |
If this is what blocks you, it has been already solved by the latest version of |
@frostming can you please make a release with this fix? all my CI pipelines will thank you for it |
Pull Request Check List
news/
describing what is new.Describe what you have changed in this PR.
It resolves the following issues, while still allows future packaging versions to be installed