You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd say that it's an issue with the solarized theme. The colors are not really hardcoded: they actually are an ANSI sequence with a particular number, and this number is associated to a particular color by the terminal/theme. When I change my theme, the colors change as well. The solarized background and the dimmed colors do not seem to play well together, but that's not something PDM (and more generally console tools) could or should really plan for (it's impossible to support themes of each and every user). Happy to hear otherwise!
If @frostming is OK for color configuration within PDM, I welcome it as well 🙂
The colors are not really hardcoded: they actually are an ANSI sequence with a particular number, and this number is associated to a particular color by the terminal/theme
That's a distinction without a difference — the fact is I can't change the colors only for this app without changing the hardcoded ANSI sequence within the app, otherwise I'd be happy to change cyan to black in my theme
The solarized background and the dimmed colors do not seem to play well together
It's not just the dimmed colors, the default also isn't great. And not just on a solarized bg: pure white background doesn't really help
It's more of an issue with cyan being used for something bigger than a symbol or two
it's impossible to support themes of each and every user
Just testing with the 2 most common backgrounds (black and white) would be fine, no need for ∞
Also, using default foreground colors would avoid this mistake since they're properly set everywhere by the user choosing the theme
And allowing user config is always a good escape from having to design everything yourself!
Impossible Is Nothing™
There's no configuration for it, but I could be wrong
Weird, we only apply the bold style here, and the text color should follow the default theme color. Here is what it looks like on my side, mac terminal with default theme:
Activity
pawamoy commentedon Oct 19, 2022
I'd say that it's an issue with the solarized theme. The colors are not really hardcoded: they actually are an ANSI sequence with a particular number, and this number is associated to a particular color by the terminal/theme. When I change my theme, the colors change as well. The solarized background and the dimmed colors do not seem to play well together, but that's not something PDM (and more generally console tools) could or should really plan for (it's impossible to support themes of each and every user). Happy to hear otherwise!
If @frostming is OK for color configuration within PDM, I welcome it as well 🙂
eugenesvk commentedon Oct 19, 2022
That's a distinction without a difference — the fact is I can't change the colors only for this app without changing the hardcoded ANSI sequence within the app, otherwise I'd be happy to change cyan to black in my theme
It's not just the dimmed colors, the default also isn't great. And not just on a solarized bg: pure white background doesn't really help
It's more of an issue with
cyan
being used for something bigger than a symbol or twoJust testing with the 2 most common backgrounds (black and white) would be fine, no need for ∞
Also, using default foreground colors would avoid this mistake since they're properly set everywhere by the user choosing the theme
And allowing user config is always a good escape from having to design everything yourself!
Impossible Is Nothing™
laike9m commentedon Jul 6, 2023
Having the same issue under a light solarized shell theme
There's no configuration for it, but I could be wrong
https://pdm.fming.dev/latest/reference/configuration/#color-theme
frostming commentedon Jul 6, 2023
Weird, we only apply the
bold
style here, and the text color should follow the default theme color. Here is what it looks like on my side, mac terminal with default theme:laike9m commentedon Jul 6, 2023
Found out it's iterm2 that overrides this..after turning it off things work fine.