Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using some characters in ProjectName breaks generated code #111

Closed
NoTuxNoBux opened this issue May 16, 2023 · 0 comments
Closed

Using some characters in ProjectName breaks generated code #111

NoTuxNoBux opened this issue May 16, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@NoTuxNoBux
Copy link

It's a nitpick and not blocking or anything, but using characters such as dots in ProjectName in the YAML files breaks the generated code in places such as ConnectionStringOptions because it causes code to be generated that may not contain dots, such as variables.

These should probably just be blocked from being used in the CLI tool.

Steps to reproduce

Example YAML:

DomainName: API
BoundedContexts:
    - ProjectName: Some.API
      DbContext:
          ContextName: APIDatabaseContext
          DatabaseName: Main
          Provider: postgres
      Entities:
          - Name: User
            Features:
                - Type: AddRecord
                - Type: GetRecord
                - Type: GetList
                - Type: UpdateRecord
                - Type: DeleteRecord
            Properties:
                - Name: Firstname
                  Type: string
                  CanFilter: true
                  CanSort: true

Then run:

craftsman new domain testfile.yaml

Further technical details

Craftsman version (dotnet tool list -g): 0.20.0
@NoTuxNoBux NoTuxNoBux added the bug Something isn't working label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NoTuxNoBux