Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in README #60

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix typo in README #60

wants to merge 2 commits into from

Conversation

jcottom
Copy link

@jcottom jcottom commented May 29, 2024

The README mentions a PLAYDATE_SDK environment variable where it should read PLAYDATE_SDK_PATH. This tripped me up when I tried to set up crank and crankstart and I found the original error message cryptic:

$ crank run --release --example hello_world
    Finished `release` profile [optimized] target(s) in 0.04s
Error: No such file or directory (os error 2)

With this change, it now shows:

$ crank run --release --example hello_world
    Finished `release` profile [optimized] target(s) in 0.01s
Error: Command failed: "/home/jack/Developer/PlaydateSDK/bin/pdc" "--strip" "/home/jack/repos/crankstart/target/Hello World" "/home/jack/repos/crankstart/target/Hello World.pdx"

Caused by:
    No such file or directory (os error 2)

which is a little more legible.

boozook
boozook requested changes Aug 11, 2024
View reviewed changes
Copy link
Member

@boozook boozook left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. But seems to there is missed import.
That's strange because it's on windows only 🤷🏻‍♂️.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boozook boozook boozook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcottom @boozook