Add onClick prop to NotificationStack definition #149
Conversation
|
This is released as |
|
Thanks @pburtchaell ! Any chance that you can publish the new version to npm? |
|
Sure, sorry for the delay. I thought it was published... let me check! |
|
Okay @sh3nan1gans, it should be released now. I'm sorry for the confusion there. Enjoy! |
|
@pburtchaell - I'm having issues with installing the latest release. Looks like an issue with the generate-lockfile script. Here's a repro repo - https://github.com/sh3nan1gans/test-install-react-notification |
|
Okay, thanks. I'll take a look. |
|
The changes in PR #145 should fix this because I removed the generate-lockfile script in that PR. |
|
Would you mind installing that branch (PR #145), @sh3nan1gans, and letting me know if you get the error? The branch is rebased from master and includes the commits from this PR. |
|
You can install it with: |
|
@pburtchaell - That branch worked perfectly 👍 |
|
Great! I will get that merged and published. 😄 |
|
Also, thanks for your contribution and your help debugging! 💯 |
|
Awesome. Thank you! And thanks for this great library |
Hello! 👋
This template enables you to open an issue that is valuable for you, the project, and the GitHub community. 💕
Before submitting an issue, please:
If you are new to open source, check out this 38 minute course on how to contribute to open source on GitHub. It's free! 😄
Before submitting a pull request, please make sure the following is done:
npm testIn order to merge your Pull Request, tests and documentation are required.