Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase safety of findConfig #10400

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix: increase safety of findConfig #10400

merged 1 commit into from
Jan 6, 2025

Conversation

denolfe
Copy link
Member

@denolfe denolfe commented Jan 6, 2025

If @payload-config is not set in tsconfig, findConfig could fail when performing a path.extname on an undefined value.

Example error in this scenario:

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined.

@denolfe denolfe changed the title fix: increase safety in findConfig fix: increase safety of findConfig Jan 6, 2025
@denolfe denolfe enabled auto-merge (squash) January 6, 2025 18:26
@denolfe denolfe disabled auto-merge January 6, 2025 19:11
@denolfe denolfe merged commit f629709 into main Jan 6, 2025
77 of 79 checks passed
@denolfe denolfe deleted the fix/safe-find-config branch January 6, 2025 19:11
Copy link
Contributor

github-actions bot commented Jan 7, 2025

🚀 This is included in version v3.15.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant