Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(richtext-lexical)!: greatly simplify lexical loading and improve performance #8041

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

AlessioGr
Copy link
Member

@AlessioGr AlessioGr commented Sep 3, 2024

We noticed that we can bring functions down to the client directly without having to wrap them in a component first. This greatly simplifies the loading of all lexical client components

BREAKING:

  • createClientComponent is no longer exported as it's not needed anymore
  • The exported ClientComponentProps type has been renamed to BaseClientFeatureProps.
  • The order of arguments in sanitizeClientEditorConfig has changed

@AlessioGr AlessioGr enabled auto-merge (squash) September 3, 2024 15:04
@AlessioGr AlessioGr changed the title perf(richtext-lexical): greatly simplify lexical loading and improve performance perf(richtext-lexical)!: greatly simplify lexical loading and improve performance Sep 3, 2024
@AlessioGr AlessioGr disabled auto-merge September 3, 2024 15:12
@AlessioGr AlessioGr enabled auto-merge (squash) September 3, 2024 15:12
@denolfe denolfe disabled auto-merge September 3, 2024 16:48
@denolfe denolfe merged commit b6a8d1c into beta Sep 3, 2024
45 of 46 checks passed
@denolfe denolfe deleted the feat/greatly-simplify-lexical branch September 3, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants