Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement UsaBannerContent component #10

Closed
Tracked by #8
patrickcate opened this issue Oct 30, 2021 · 1 comment
Closed
Tracked by #8

Implement UsaBannerContent component #10

patrickcate opened this issue Oct 30, 2021 · 1 comment
Assignees
@patrickcate
Labels
feature New feature or request

Comments

@patrickcate
Copy link
Owner

patrickcate commented Oct 30, 2021 •
edited
Loading

Banner Content

The banner content.

Props

Name Type Default Required Options
open Boolean n/a true n/a
id String n/a true n/a
domain String n/a true n/a

Slots

  • default
  • domain-guidance
  • https-guidance

CSS Classes

  • open: usa-banner__header--expanded

External Libraries

  • None

Sub-Components

  • None

Dependencies

  • UsaAccordion
  • v-toggle

Notes

  • The default content for slots should be the standard english language text.
  • Should the hidden value only be set after the component is mounted in case JS fails?

Tests

  1. The hidden attribute is toggled based on the open prop.
  2. The open prop is required.
  3. The id prop is required.
  4. The domain prop is required.
@patrickcate patrickcate mentioned this issue Oct 30, 2021
Closed
4 tasks
@patrickcate patrickcate changed the title UsaBannerContent Implement UsaBannerContent component Oct 30, 2021
@patrickcate patrickcate added the feature New feature or request label Nov 11, 2021
patrickcate added a commit that referenced this issue Dec 21, 2021
@patrickcate
feat: implement UsaBanner and UsaBannerContent components
7b396de 
ISSUES CLOSED: #8, #10
@patrickcate
Copy link
Owner Author

Implemented in 7b396de

@patrickcate patrickcate self-assigned this Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrickcate patrickcate

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@patrickcate