-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manipulating another cell #54
Comments
When you say "change the cell", do you mean changing their selection state? |
Ok, i see, youre trying to implement range selection. This is a feature i am currently working on. It will be done in such a way that the user can drag select their dates. I like that you are doing awesome things with this calendar. But its difficult for me to know what youre doing to generate those views without seeing any code. But I do understand that that your project is sensitive. So here are our options. You can do any one of the following.
a) Does reloadIndexPathsIfVisible(pathsFromDates(dates)) we are reloading some IndexPaths from the dates you have provided if they are visible on the screen. Can you change the code to the following and repeat (a) and (b) above ? delayRunOnGlobalThread(0.0, qos: QOS_CLASS_USER_INITIATED) {
let allPathsFromDates = self.pathsFromDates(dates)
self.reloadIndexPathsIfVisible(allPathsFromDates)
} Let me know if you have done anything to fix it. Let's make this library even better. |
Thanks you are very helpful, I appreciate that. So I proceed by creating the non-sensitive code of the calendar, I hope that once you download it you would remove it from this list. PS: Sorry in advance if my code is messy and not correctly implemented, I'm still learning. |
Btw, if you have things you dont want posted here, you can always ask for my email. Taking a look at your work now. |
I think ive found the reason for the slow animation. Working on a fix. |
Hey, i just uploaded the fix to the master branch. How soon are you able to test it? |
Hi, thanks. I will test it right away.. |
To test the master branch with your current project do this: Go to your pod file, and change your JTAppleCalendar pod to this:
Then do a:
This will let you use the latest code. Try it out and let me know |
I tested with the new release with my code untouched and what happen is after I selected a cell, I can't deselect it back, and the state of the cell stays selected, I did print out the selected dates (on the console) to verify this. |
Are you online now? Can you join me here? --> https://gitter.im/patchthecode/JTAppleCalendar |
Issue solved. |
Hey I have one other question for you: I was going to implement a range selection feature for this calendar. I wanted to do it, but if this calendar is already flexible enough that users can already do range selection, then do you think that it is needed from my end? or not? I will decide whether or not to make it based on your answer to this question:
Is this possible to do with your app easily? Or is there something this library can do to make this easier? |
I haven't tried out the tap and slide before, but its going to be a nice feature. I could try to implement it and see how beneficial it brings to my project in particular.. If you can wait I can try and send you feedback on whether it is easy (successfully) or not to implement it.. But generally speaking, this is related to the library, and I myself think it is a great feature to have |
Well that's the thing. Its meant to be a library. It's meant to enable a dev to build the feature him self if needed. Think about the So let me know how difficult it is, to implement. (if you're taking a while to implement it then I might just do it to see my self) But on the whole, I will think about it if you're busy with your project and are taking a while to implement. |
Haha, it seems that since you have put up that range selection, many people are asking me how to implement it >_< |
I just added Range selection to master branch. |
Hey, sorry for late reply. |
I was just wondering if it is possible to manipulate another cell when the user tap a cell.
For example, when I tap 24 June cell, it will then change the cell for date 28, 29, 30th June also.
If its possible could you shed some light on how to achieve this?
The text was updated successfully, but these errors were encountered: