Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build after #1427 #1444

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Fix build after #1427 #1444

merged 1 commit into from
Apr 24, 2024

Conversation

alancai98
Copy link
Member

@alancai98 alancai98 commented Apr 24, 2024 •
edited
Loading

Description

I added the binary compatibility checks in #1427 but had not pulled in the latest changes from the v1 branch (which included some public API changes), so the result of the apiCheck step after I merged #1427 to v1 branch failed.

This PR fixes those errors by running the following:

> git checkout v1
> git pull
> ./gradlew apiDump

# create branch, commit, push, pr

Other Information

  • Updated Unreleased Section in CHANGELOG: [NO]

    • No public API changes

  • Any backward-incompatible changes? [YES]

  • Any new external dependencies? [NO]

  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES]

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alancai98 alancai98 requested a review from rchowell April 24, 2024 21:24
@alancai98 alancai98 self-assigned this Apr 24, 2024
@github-actions GitHub Actions
Copy link

Conformance comparison report-Cross Engine

Base (legacy) eval +/-
% Passing 92.51% 90.67% -1.84%
✅ Passing 5382 5276 -106
❌ Failing 436 543 107
🔶 Ignored 0 0 0
Total Tests 5818 5819 1
Number passing in both: 5071

Number failing in both: 231

Number passing in legacy engine but fail in eval engine: 312

Number failing in legacy engine but pass in eval engine: 205
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.
205 test(s) were failing in legacy but now pass in eval. Before merging, confirm they are intended to pass.
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-LEGACY

Base (801091c) 9568825 +/-
% Passing 92.51% 92.51% 0.00%
✅ Passing 5382 5382 0
❌ Failing 436 436 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0
Number passing in both: 5382

Number failing in both: 436

Number passing in Base (801091c) but now fail: 0

Number failing in Base (801091c) but now pass: 0

Conformance comparison report-Cross Commit-EVAL

Base (801091c) 9568825 +/-
% Passing 90.67% 90.67% 0.00%
✅ Passing 5276 5276 0
❌ Failing 543 543 0
🔶 Ignored 0 0 0
Total Tests 5819 5819 0
Number passing in both: 5276

Number failing in both: 543

Number passing in Base (801091c) but now fail: 1

Number failing in Base (801091c) but now pass: 1
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️. The following test(s) were previously passing but now fail:

Click here to see
  • Example 6 — Value Coercion, compileOption: LEGACY
The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:
Click here to see
  • Example 6 — Value Coercion, compileOption: LEGACY

@alancai98 alancai98 merged commit 1bb5577 into v1 Apr 24, 2024
14 checks passed
@alancai98 alancai98 deleted the fix-build-after-1427 branch April 24, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchowell rchowell rchowell approved these changes

Assignees

@alancai98 alancai98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alancai98 @rchowell