Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add password validation for user with unverified email via Parse.User.verifyPassword using master key and option ignoreEmailVerification: true #2076

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Jan 17, 2024

Pull Request

Issue

Closes: #2077

Approach

Remove option filter.

Tasks

  • Add tests

Copy link

parse-github-assistant bot commented Jan 17, 2024

Thanks for opening this pull request!

@mtrezza mtrezza changed the title fix: Remove request option limitation in Parse.User.verifyPassword feat: Add password validation for user with unverified email with Parse.User.verifyPassword using master key and option ignoreEmailVerification: true Mar 23, 2024
mtrezza added 4 commits March 23, 2024 03:16
…rification

* alpha:
  chore(release): 5.0.0-beta.1 [skip ci]
  chore(release): 5.0.0-alpha.3 [skip ci]
  feat: Add comment to MongoDB query via `Parse.Query.comment` (parse-community#2088)
  chore(release): 5.0.0-alpha.2 [skip ci]
  feat: Add compatibility with Parse Server 7 (parse-community#2089)
  chore(release): 5.0.0-alpha.1 [skip ci]
  feat: Add support for Node 20, remove support for Node 14 and 16 (parse-community#2063)
  refactor: Upgrade ws from 8.15.1 to 8.16.0 (parse-community#2087)
  ci: Remove manual caching for `actions/setup-node` (parse-community#2064)
  chore(release): 4.3.1-alpha.2 [skip ci]
  fix: Calling `Parse.Object.relation.add` multiple times adds only the first object (parse-community#2078)
  refactor: Upgrade ws from 8.15.0 to 8.15.1 (parse-community#2074)
  chore(release): 4.3.1 [skip ci]
  release
@mtrezza mtrezza closed this Mar 23, 2024
@mtrezza mtrezza reopened this Mar 23, 2024
@mtrezza mtrezza changed the title feat: Add password validation for user with unverified email with Parse.User.verifyPassword using master key and option ignoreEmailVerification: true feat: Add password validation for user with unverified email via Parse.User.verifyPassword using master key and option ignoreEmailVerification: true Mar 23, 2024
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.98%. Comparing base (9449cc3) to head (e699861).
Report is 19 commits behind head on alpha.

Files Patch % Lines
src/RESTController.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             alpha    #2076      +/-   ##
===========================================
- Coverage   100.00%   99.98%   -0.02%     
===========================================
  Files           61       61              
  Lines         6178     6184       +6     
  Branches      1496     1499       +3     
===========================================
+ Hits          6178     6183       +5     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza merged commit b0adf7e into parse-community:alpha Mar 23, 2024
7 of 9 checks passed
@mtrezza mtrezza deleted the fix-remove-option-limitation-in-password-verification branch March 23, 2024 03:16
parseplatformorg pushed a commit that referenced this pull request Mar 23, 2024
# [5.0.0-alpha.4](5.0.0-alpha.3...5.0.0-alpha.4) (2024-03-23)

### Features

* Add password validation for user with unverified email via `Parse.User.verifyPassword` using master key and option `ignoreEmailVerification: true` ([#2076](#2076)) ([b0adf7e](b0adf7e))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-alpha.4

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Mar 23, 2024
parseplatformorg pushed a commit that referenced this pull request Mar 31, 2024
# [5.1.0-alpha.1](5.0.0...5.1.0-alpha.1) (2024-03-31)

### Features

* Add password validation for user with unverified email via `Parse.User.verifyPassword` using master key and option `ignoreEmailVerification: true` ([#2076](#2076)) ([b0adf7e](b0adf7e))
* Add support for setting `Parse.ACL` from json ([#2097](#2097)) ([72bc9ac](72bc9ac))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0-alpha.1

parseplatformorg pushed a commit that referenced this pull request May 16, 2024
# [5.1.0-beta.1](5.0.0...5.1.0-beta.1) (2024-05-16)

### Bug Fixes

* `Parse.GeoPoint.current` returns `undefined` ([#2127](#2127)) ([3860535](3860535))
* Chrome browser console warning about unsafe header `access-control-expose-headers` when calling Cloud Function ([#2095](#2095)) ([7b73c03](7b73c03))
* Live Query not working on Expo React Native ([#2109](#2109)) ([7a89665](7a89665))
* Local datastore throws error when `Parse.Query.notEqualTo` is set to `null` ([#2102](#2102)) ([6afd32a](6afd32a))
* Multiple object updates of nested keys overwrite each other ([#1451](#1451)) ([fa4341a](fa4341a))
* Pending updates to nested field causes `ParseObject.toJSON()` to return incorrect object ([#1453](#1453)) ([23cc573](23cc573))
* Remove circular dependencies ([#2125](#2125)) ([b415165](b415165))

### Features

* Add password validation for user with unverified email via `Parse.User.verifyPassword` using master key and option `ignoreEmailVerification: true` ([#2076](#2076)) ([b0adf7e](b0adf7e))
* Add support for setting `Parse.ACL` from json ([#2097](#2097)) ([72bc9ac](72bc9ac))
* Allow setting custom queue for handling offline operations via `Parse.EventuallyQueue` ([#2106](#2106)) ([f92e4d4](f92e4d4))
* Improve installation object `Parse.Installation.currentInstallation` to support web push notifications ([#2119](#2119)) ([4fc62ce](4fc62ce))
* Lazy load `Parse.CoreManager` controllers to add support for swappable `CryptoController`, `LocalDatastoreController`, `StorageController`, `WebSocketController`, `ParseLiveQuery` ([#2100](#2100)) ([fbd0ab1](fbd0ab1))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label May 16, 2024
parseplatformorg pushed a commit that referenced this pull request May 16, 2024
# [5.1.0](5.0.0...5.1.0) (2024-05-16)

### Bug Fixes

* `Parse.GeoPoint.current` returns `undefined` ([#2127](#2127)) ([3860535](3860535))
* Chrome browser console warning about unsafe header `access-control-expose-headers` when calling Cloud Function ([#2095](#2095)) ([7b73c03](7b73c03))
* Live Query not working on Expo React Native ([#2109](#2109)) ([7a89665](7a89665))
* Local datastore throws error when `Parse.Query.notEqualTo` is set to `null` ([#2102](#2102)) ([6afd32a](6afd32a))
* Multiple object updates of nested keys overwrite each other ([#1451](#1451)) ([fa4341a](fa4341a))
* Pending updates to nested field causes `ParseObject.toJSON()` to return incorrect object ([#1453](#1453)) ([23cc573](23cc573))
* Remove circular dependencies ([#2125](#2125)) ([b415165](b415165))

### Features

* Add password validation for user with unverified email via `Parse.User.verifyPassword` using master key and option `ignoreEmailVerification: true` ([#2076](#2076)) ([b0adf7e](b0adf7e))
* Add support for setting `Parse.ACL` from json ([#2097](#2097)) ([72bc9ac](72bc9ac))
* Allow setting custom queue for handling offline operations via `Parse.EventuallyQueue` ([#2106](#2106)) ([f92e4d4](f92e4d4))
* Improve installation object `Parse.Installation.currentInstallation` to support web push notifications ([#2119](#2119)) ([4fc62ce](4fc62ce))
* Lazy load `Parse.CoreManager` controllers to add support for swappable `CryptoController`, `LocalDatastoreController`, `StorageController`, `WebSocketController`, `ParseLiveQuery` ([#2100](#2100)) ([fbd0ab1](fbd0ab1))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse.User.verifyPassword does not pass request options to server
2 participants