Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for excluding keys in ParseQuery.findAll #2000

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Aug 25, 2023

Pull Request

Issue

Thanks @sadortun!

Closes: #1990

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

@parse-github-assistant
Copy link

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (54efcf5) 99.88% compared to head (c2dca91) 99.88%.

❗ Current head c2dca91 differs from pull request most recent head 3af84aa. Consider uploading reports for the commit 3af84aa to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #2000      +/-   ##
==========================================
- Coverage   99.88%   99.88%   -0.01%     
==========================================
  Files          61       61              
  Lines        6117     6116       -1     
  Branches     1491     1491              
==========================================
- Hits         6110     6109       -1     
  Misses          7        7              
Files Changed Coverage Δ
src/ParseQuery.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sadortun sadortun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@dplewis dplewis requested a review from mtrezza August 26, 2023 02:16
@mtrezza mtrezza changed the title feat: Support exclude keys in query.findAll feat: Support exclude keys in ParseQuery.findAll Aug 27, 2023
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, is this ready for merge?

@mtrezza mtrezza changed the title feat: Support exclude keys in ParseQuery.findAll feat: Add support for excluding keys in ParseQuery.findAll Aug 27, 2023
@dplewis
Copy link
Member Author

dplewis commented Aug 27, 2023

It’s ready for merge

@mtrezza mtrezza merged commit 012ba4c into parse-community:alpha Aug 27, 2023
parseplatformorg pushed a commit that referenced this pull request Aug 27, 2023
# [4.2.0-alpha.5](4.2.0-alpha.4...4.2.0-alpha.5) (2023-08-27)

### Features

* Add support for excluding keys in `ParseQuery.findAll` ([#2000](#2000)) ([012ba4c](012ba4c))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.2.0-alpha.5

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Aug 27, 2023
parseplatformorg pushed a commit that referenced this pull request Sep 16, 2023
# [4.3.0-beta.1](4.2.0...4.3.0-beta.1) (2023-09-16)

### Bug Fixes

* `ParseUser.linkWith` doesn't remove anonymous auth data ([#2007](#2007)) ([7e2585c](7e2585c))
* Hard-coding of `react-native` path does not work for workspace builds ([#1930](#1930)) ([8222f3c](8222f3c))

### Features

* Add Bytes type to `Parse.Schema` ([#2001](#2001)) ([343d0d7](343d0d7))
* Add Cloud Code context accessibility to `ParseUser.logIn` ([#2010](#2010)) ([2446007](2446007))
* Add support for custom EventEmitter ([#1999](#1999)) ([ca568a6](ca568a6))
* Add support for excluding keys in `ParseQuery.findAll` ([#2000](#2000)) ([012ba4c](012ba4c))
* Add support to invoke a Cloud Function with a custom `installationId` via `Parse.Cloud.run` ([#1939](#1939)) ([eb70b93](eb70b93))
* Allow overriding `Parse.Error` message with custom message via new Core Manager option `PARSE_ERRORS` ([#2014](#2014)) ([be0c8a6](be0c8a6))
* Login with username, password and additional authentication data via `ParseUser.logInWithAdditionalAuth` ([#1955](#1955)) ([2bad411](2bad411))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Sep 16, 2023
parseplatformorg pushed a commit that referenced this pull request Sep 26, 2023
# [4.3.0-alpha.1](4.2.0...4.3.0-alpha.1) (2023-09-26)

### Bug Fixes

* `ParseUser.linkWith` doesn't remove anonymous auth data ([#2007](#2007)) ([7e2585c](7e2585c))
* Hard-coding of `react-native` path does not work for workspace builds ([#1930](#1930)) ([8222f3c](8222f3c))

### Features

* Add Bytes type to `Parse.Schema` ([#2001](#2001)) ([343d0d7](343d0d7))
* Add Cloud Code context accessibility to `ParseUser.logIn` ([#2010](#2010)) ([2446007](2446007))
* Add support for custom EventEmitter ([#1999](#1999)) ([ca568a6](ca568a6))
* Add support for excluding keys in `ParseQuery.findAll` ([#2000](#2000)) ([012ba4c](012ba4c))
* Add support to invoke a Cloud Function with a custom `installationId` via `Parse.Cloud.run` ([#1939](#1939)) ([eb70b93](eb70b93))
* Allow overriding `Parse.Error` message with custom message via new Core Manager option `PARSE_ERRORS` ([#2014](#2014)) ([be0c8a6](be0c8a6))
* Login with username, password and additional authentication data via `ParseUser.logInWithAdditionalAuth` ([#1955](#1955)) ([2bad411](2bad411))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.3.0-alpha.1

parseplatformorg pushed a commit that referenced this pull request Nov 16, 2023
# [4.3.0](4.2.0...4.3.0) (2023-11-16)

### Bug Fixes

* `ParseUser.linkWith` doesn't remove anonymous auth data ([#2007](#2007)) ([7e2585c](7e2585c))
* Hard-coding of `react-native` path does not work for workspace builds ([#1930](#1930)) ([8222f3c](8222f3c))

### Features

* Add Bytes type to `Parse.Schema` ([#2001](#2001)) ([343d0d7](343d0d7))
* Add Cloud Code context accessibility to `ParseUser.logIn` ([#2010](#2010)) ([2446007](2446007))
* Add support for custom EventEmitter ([#1999](#1999)) ([ca568a6](ca568a6))
* Add support for excluding keys in `ParseQuery.findAll` ([#2000](#2000)) ([012ba4c](012ba4c))
* Add support to invoke a Cloud Function with a custom `installationId` via `Parse.Cloud.run` ([#1939](#1939)) ([eb70b93](eb70b93))
* Allow overriding `Parse.Error` message with custom message via new Core Manager option `PARSE_ERRORS` ([#2014](#2014)) ([be0c8a6](be0c8a6))
* Login with username, password and additional authentication data via `ParseUser.logInWithAdditionalAuth` ([#1955](#1955)) ([2bad411](2bad411))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 16, 2023
@sadortun
Copy link
Contributor

Thanks you @dplewis for this ⭐ !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query.findAll() doesn't use exclude/excludeKeys
4 participants