Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run integration tests against react-native #1754

Closed
3 tasks done
dplewis opened this issue Feb 8, 2023 · 1 comment · Fixed by #2100
Closed
3 tasks done

Run integration tests against react-native #1754

dplewis opened this issue Feb 8, 2023 · 1 comment · Fixed by #2100
Labels
type:ci CI related issue

Comments

@dplewis
Copy link
Member

dplewis commented Feb 8, 2023 •
edited
Loading

New Feature / Enhancement Checklist

Feature / Enhancement Description

Running tests against react-native will allow us to ensure the build works as expected and compiles. Basic tests for EventEmitter, AsyncStorage, CryptoController, LiveQuery and LocalDataStore should be enough.

A good starting point would be to change the LDS tests and create a ParseReactNativeTest suite

Parse-SDK-JS/integration/test/ParseLocalDatastoreTest.js

Lines 2960 to 2963 in 44d1cde

{
name: 'React-Native',
file: '../../lib/node/LocalDatastoreController.react-native',
},

This should be ../../lib/react-native/LocalDatastoreController.react-native
@parse-github-assistant
Copy link

parse-github-assistant bot commented Feb 8, 2023 •
edited
Loading

Thanks for opening this issue!

  • ❌ Please edit your post and use the provided template when creating a new issue. This helps everyone to understand your post better and asks for essential information to quicker review the issue.

@mtrezza mtrezza added the type:ci CI related issue label Feb 9, 2023
@dplewis dplewis mentioned this issue Aug 6, 2023
Closed
@dplewis dplewis mentioned this issue Apr 12, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:ci CI related issue
Projects
None yet
Milestone
No milestone
2 participants
@mtrezza @dplewis