This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Telemetry improvements #1886
Merged
Telemetry improvements #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
reviewed
Feb 27, 2019
bkchr
reviewed
Feb 27, 2019
bkchr
reviewed
Feb 28, 2019
|
On telemetry side everything looks fine to me. Tested the branch running against local telemetry server on both Dried Danta and dev chain, no issues. |
bkchr
approved these changes
Feb 28, 2019
rphmeier
pushed a commit
that referenced
this pull request
Feb 28, 2019
* Fix typo * Support multiple telemetry endpoints and verbosity levels * Bump substrate-telemetry version * Telemetrify Aura consensus * Telemetrify Grandpa * Fix CI version conflicts * Implement style remarks * Fix fixture * Implement style remarks * Clone only when necessary * Get rid of Arc for URL * Handle connection issues better
rphmeier
added a commit
that referenced
this pull request
Feb 28, 2019
* Telemetry improvements (#1886) * Fix typo * Support multiple telemetry endpoints and verbosity levels * Bump substrate-telemetry version * Telemetrify Aura consensus * Telemetrify Grandpa * Fix CI version conflicts * Implement style remarks * Fix fixture * Implement style remarks * Clone only when necessary * Get rid of Arc for URL * Handle connection issues better * fixed instant finalization of genesis block on light client (#1898) * Some gossip improvements (#1892) * queue messages in future * use new gossip API in GRANDPA * implement message_expired for grandpa * fix indent
rphmeier
reviewed
Feb 28, 2019
rphmeier
reviewed
Feb 28, 2019
|
Lots of glob imports (huge code smell). Please make a follow-up to remove them. |
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Apr 12, 2019
* Fix typo * Support multiple telemetry endpoints and verbosity levels * Bump substrate-telemetry version * Telemetrify Aura consensus * Telemetrify Grandpa * Fix CI version conflicts * Implement style remarks * Fix fixture * Implement style remarks * Clone only when necessary * Get rid of Arc for URL * Handle connection issues better
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should close #1734.
There is a lot more stuff in Grandpa/Aura which could be telemetrified ‒ if the general approach is okay I would add a
telemetry!next to the otherdebug!/info!/… statements in the consensus modules as well.I tested it using
cargo run -- --dev --telemetry-url "ws://localhost:8001" --telemetry-url "ws://localhost:8002 9"with two simple WebSocket echo servers.