This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Limit the set of known extrinsics and blocks. #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepyakin
reviewed
Feb 21, 2019
core/network/src/util.rs
Outdated
| /// Maintains the limit of the set by removing the oldest entry if necessary. | ||
| pub(crate) fn insert(&mut self, e: T) -> bool { | ||
| if self.set.len() == usize::from(self.limit) { | ||
| if self.set.contains(&e) { |
There was a problem hiding this comment.
I'm not sure about the runtime characteristics of the contains function, but we could always insert optimistically, and then pop_front if needed. This way this will have only one lookup.
There was a problem hiding this comment.
I think insert and contains are both O(1) but your proposal is still more efficient. Also I just learned that inserting existing elements still updates their LRU position which my version does not.
Always inserting first ensures that the element's LRU position is updated.
gavofyork
approved these changes
Feb 21, 2019
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Apr 12, 2019
* Limit the set of known extrinsics and blocks. * Update Cargo.lock * Always insert and pop oldest entry if needed. Always inserting first ensures that the element's LRU position is updated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The set of known extrinsics and blocks per peer currently grows unbounded. This PR attempts to replace those sets with bounded LRU sets.
Open question: What would be a good upper bound? Is 1_000_000 too high?
Part of paritytech/polkadot-sdk#569.