This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Migrate finality-grandpa to the 2018 edition #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have 3 open and substantial PRs for finality-grandpa -- I would guess that all of them have conflicts with this. Maybe we should ice this? |
|
Is this is an insubstantial PR, it should be fairly easy to integrate into the others? What is holding the others of being merged? |
|
I don't insist on merging: these are relatively simple changes that can be done later. |
stanislav-tkach
force-pushed
the
stas-2018-grandpa
branch
from
642e2b4 to
9bbc646
Compare
|
Sure, let's just merge this then. |
rphmeier
added
A8-looksgood
and removed
A0-please_review
rphmeier
approved these changes
Feb 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally several "variable does not need to be mutable" warnings have been fixed and the unused
hex-literaldependency has been removed.Closes #1783.