Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Limit transaction pool size #1676

Merged
merged 9 commits into from
Feb 6, 2019
Merged

Limit transaction pool size #1676

merged 9 commits into from
Feb 6, 2019

Conversation

tomusdrw
Copy link
Contributor

@tomusdrw tomusdrw commented Feb 4, 2019

  • Both ready and future.
  • Limit by transaction size of count.
  • Expose the setting to CLI (only ready, future is always 10% of the ready queue).

Closes #1579

@tomusdrw tomusdrw added A0-please_review Pull request needs code review. M4-core labels Feb 4, 2019
@gavofyork gavofyork merged commit 57a2d81 into master Feb 6, 2019
@gavofyork gavofyork deleted the td-pooloptions branch February 6, 2019 18:03
MTDK1 pushed a commit to bdevux/substrate that referenced this pull request Apr 12, 2019
@tomusdrw @MTDK1
Limit transaction pool size (paritytech#1676)
b15efa8 
* Avoid excessive hashing. Store extrinsic len.

* Implement pool limits.

* Fix issues.

* Make sure we return error in case it doesn't make into the pool.

* Pass parameters from CLI.

* Remove redundant todo.

* Fix tests.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gavofyork gavofyork gavofyork approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomusdrw @gavofyork