Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

docker container build with redis_exporter #127

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Conversation

gabreal
Copy link
Contributor

@gabreal gabreal commented Dec 11, 2019

deployment suggestion: https://mehmandarov.com/start-docker-containers-automatically/ running it inside docker with systemd.

@lovelaced
Copy link
Contributor

Thanks for this! Building in a docker image seems pretty easy and convenient. Out of curiosity, why not just rely on the docker daemon to autostart the image: https://docs.docker.com/config/containers/start-containers-automatically/
I found some gotchas about using systemd to control running docker containers in this post, but it is a bit "old" in terms of docker maturity: https://blog.container-solutions.com/running-docker-containers-with-systemd

@gabreal
Copy link
Contributor Author

gabreal commented Dec 12, 2019

@lovelaced thanks for the links. My initial thoughts were that systemd would be more transparent and mature in handling system level jobs. Also that you would not have a dependency to think of anything when restarting the docker daemon. But another good argument from the article above:

Using systemd or an equivalent is particularly useful if you have another, possibly non-containerized service that is dependent on the container.

But I guess I would prefer to run it via systemd even when running containerized redis, or would it be possible to declare dependencies in docker?

@gabreal gabreal merged commit 8e8b56a into master Dec 12, 2019
@gabreal gabreal deleted the redis_exporter branch December 12, 2019 22:35
@TriplEight
Copy link
Contributor

👍

@gabreal
Copy link
Contributor Author

gabreal commented Dec 16, 2019

That's the deployment: https://gitlab.parity.io/parity/devops/merge_requests/45

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants