Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pallet-revive] fee estimation fixes #7281

Merged
merged 8 commits into from
Jan 23, 2025
Merged

[pallet-revive] fee estimation fixes #7281

merged 8 commits into from
Jan 23, 2025

Conversation

pgherveou
Copy link
Contributor

@pgherveou pgherveou commented Jan 21, 2025 •
edited
Loading

  • Fix the EVM fee cost estimation.
    The estimation shown in EVM wallet was using Native instead of EVM decimals
  • Remove the precise code length estimation in dry run call. Over-estimating is fine, since extra gas is refunded anyway.
  • Ensure that the estimated fee calculated from gas_price x gas use the encoded weight & deposit limit instead of the exact one calculated by the dry-run. Else we can end up with a fee that is lower than the actual fee paid by the user

@pgherveou
Copy link
Contributor Author

/cmd prdoc --audience runtime_dev --bump minor

@pgherveou pgherveou added T7-smart_contracts This PR/Issue is related to smart contracts. R0-silent Changes should not be mentioned in any release notes labels Jan 21, 2025
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12892167290
Failed job name: test-linux-stable

@pgherveou pgherveou changed the title [pallet-revive] fix eth fee estimation [pallet-revive] fee estimation fixes Jan 22, 2025
@pgherveou pgherveou requested review from athei and xermicus January 22, 2025 22:55
athei
athei approved these changes Jan 23, 2025
View reviewed changes
substrate/frame/revive/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/revive/src/lib.rs Outdated Show resolved Hide resolved
substrate/bin/node/runtime/src/lib.rs Show resolved Hide resolved
@pgherveou pgherveou enabled auto-merge January 23, 2025 09:14
@pgherveou pgherveou disabled auto-merge January 23, 2025 09:14
@pgherveou pgherveou enabled auto-merge January 23, 2025 09:22
@pgherveou pgherveou added this pull request to the merge queue Jan 23, 2025
Merged via the queue into master with commit 5772b9d Jan 23, 2025
195 of 205 checks passed
@pgherveou pgherveou deleted the pg/fix-evm-tip branch January 23, 2025 10:34
@athei athei mentioned this pull request Jan 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xermicus xermicus xermicus approved these changes

@athei athei athei approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T7-smart_contracts This PR/Issue is related to smart contracts.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgherveou @athei @xermicus