This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Companion: Rename pallet trait Trait to Config
#2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
added
the
A4-companion
ordian
reviewed
Nov 25, 2020
ordian
added
B0-silent
gui1117
commented
Nov 25, 2020
| /// The active configuration for the current session. | ||
| Config get(fn config) config(): HostConfiguration<T::BlockNumber>; | ||
| HostConfig get(fn config) config(): HostConfiguration<T::BlockNumber>; |
There was a problem hiding this comment.
note for reviewer: this conflicted thus I changed to HostConfig
There was a problem hiding this comment.
I guess this pallet is used in some test chains, thus it needs to be migrated, I open such migration/rename in an independant PR for ease reviewing. #2036
I renamed to ActiveConfig, but as it is not used yet, I didn't do migration
gui1117
added
A3-in_progress
ordian
approved these changes
Nov 30, 2020
ordian
added
A8-mergeoncegreen
and removed
A3-in_progress
gui1117
added
A0-please_review
|
Waiting for commit status. |
|
Merge failed: |
|
Looks like #2038 sneaked in causing a merge conflict. |
|
bot merge |
|
Missing process info; check that the PR belongs to a project column. Merge can be attempted if:
|
kianenigma
approved these changes
Nov 30, 2020
shawntabrizi
approved these changes
Nov 30, 2020
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the pallet trait Trait to Config.
Config storage in Configuration pallet is also renamed ActiveConfig. This doesn't need a migration as Configuration pallet is not used yet. (#2036 )
companion of paritytech/substrate#7599