Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Updating the Docker instructions for latest 0.3.14 polkadot Alexander #135

Merged
merged 2 commits into from
Feb 20, 2019

Conversation

mradkov
Copy link
Contributor

@mradkov mradkov commented Feb 12, 2019

I've updated the Docker instructions for running the latest 0.3.14 Polkadot node on Alexander testnet

Also added --chain alex argument to the command lines, which was an important change and wasn't mentioned in the doc.

Thanks to @chevdor for the assistance!

- update to latest docker polkadot version - 0.3.14
- add the `--chain alex` argument which is necessary for the Alexander testnet
add custom node name
@parity-cla-bot
Copy link

It looks like @mradkov hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@mradkov
Copy link
Contributor Author

mradkov commented Feb 12, 2019

[clabot:check]

@parity-cla-bot
Copy link

It looks like @mradkov signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@chevdor
Copy link
Contributor

chevdor commented Feb 12, 2019

Thanks for taking the time to make the PR @mradkov.
It looks correct to me and this fix of the doc will likely help many who are still omitting --chain alex.

@ddorgan
Copy link
Member

ddorgan commented Feb 12, 2019

Any reason not to use the images parity/polkadot:latest or say parity/polkadot:0.3.14-2a5e8fc ?

@mradkov
Copy link
Contributor Author

mradkov commented Feb 12, 2019

Any reason not to use the images parity/polkadot:latest or say parity/polkadot:0.3.14-2a5e8fc ?

I haven't changed this, to be consistent with what was documented in the file.

Maybe @chevdor can tell if there is any difference between the two.

@chevdor
Copy link
Contributor

chevdor commented Feb 12, 2019

Any reason not to use the images parity/polkadot:latest or say parity/polkadot:0.3.14-2a5e8fc ?

yes, because initially, there were no such images.
I wrote the initial doc along with the chevdor/polkadot image that I still maintain.

I am however not using the parity image so I have no clue if it works with the doc we currently have.

IMO, switching the container source belongs to another PR.
Here @mradkov is updating so users can still use the image with the latest changes.

@gavofyork
Copy link
Member

@ddorgan merge when ready.

Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gavofyork gavofyork merged commit d13c7ee into paritytech:master Feb 20, 2019
tomusdrw pushed a commit that referenced this pull request Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants