Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

"Last Change" in Implementer's Guide is broken #6284

Closed
mrcnski opened this issue Nov 14, 2022 · 1 comment · Fixed by #6306 or #6335
Closed

"Last Change" in Implementer's Guide is broken #6284

mrcnski opened this issue Nov 14, 2022 · 1 comment · Fixed by #6306 or #6335

Comments

@mrcnski
Copy link
Contributor

mrcnski commented Nov 14, 2022 •
edited
Loading

ISSUE

Overview

The new "last change" feature is not working (see footer):

https://paritytech.github.io/polkadot/book/pvf-prechecking.html

I believe this is because in GitLab CI we have a git depth of 100, so it is not getting the full commit history. See line 14:

https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2042805

Proposed Change(s)

  1. Do a full git clone for the build-implementers-guide job only (might be fine if we only do this on PR merge?) (are there any speed/memory restrictions on GitLab CI?) cc @paritytech/ci @sergejparity

  2. Or, scrap this feature if we don't have access to the full history.
@alvicsam alvicsam mentioned this issue Nov 17, 2022
Merged
@mrcnski
Copy link
Contributor Author

mrcnski commented Nov 18, 2022

Reopening as the issue seems to be persisting.

Looking at the build job it seems that the git depth is no longer being reported at 100:
https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2059294

Not sure what the issue could be, maybe someone at @paritytech-ci has some ideas?

@mrcnski mrcnski reopened this Nov 18, 2022
@alvicsam alvicsam mentioned this issue Nov 23, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mrcnski