fix: generate docs behind features #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
commented
May 4, 2022
| jsonrpsee-types = { path = "../types", version = "0.11.0", package = "jsonrpsee-types", optional = true } | ||
| jsonrpsee-http-client = { path = "../client/http-client", version = "0.11.0", optional = true } | ||
| jsonrpsee-ws-client = { path = "../client/ws-client", version = "0.11.0", optional = true } | ||
| jsonrpsee-wasm-client = { path = "../client/wasm-client", version = "0.11.0", optional = true } |
There was a problem hiding this comment.
note added jsonrpsee-wasm-client here
dvdplm
approved these changes
May 4, 2022
lexnv
approved these changes
May 4, 2022
jsdw
reviewed
May 5, 2022
jsonrpsee/src/macros.rs
Outdated
Comment on lines
89
to
97
| macro_rules! cfg_proc_macros { | ||
| ($($item:item)*) => { | ||
| $( | ||
| #[cfg(feature = "jsonrpsee-proc-macros")] | ||
| #[cfg_attr(docsrs, doc(cfg(feature = "jsonrpsee-proc-macros")))] | ||
| $item | ||
| )* | ||
| } | ||
| } |
There was a problem hiding this comment.
Would it make sense to write a macro like:
macro_rules! cfg_feature {
($feature:literal, $($item:item)*) => {
$(
#[cfg(feature = $feature)]
#[cfg_attr(docsrs, doc(cfg(feature = $feature)))]
$item
)*
}
}And then most of the other macros across these crates can just call that internally like:
macro_rules! cfg_proc_macros {
($($item:item)*) => cfg_feature!("jsonrpc-proc-macros", $($item:item)*)
}There seem like enough copies to justify it :)
jsdw
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #668