impl Stream on Subscription and tweak built-in next() method to align #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
reviewed
Dec 10, 2021
types/src/client.rs
Outdated
| type Item = Result<Notif, Error>; | ||
| fn poll_next(mut self: Pin<&mut Self>, cx: &mut task::Context<'_>) -> task::Poll<Option<Self::Item>> { | ||
| let n = futures_util::ready!(self.notifs_rx.poll_next_unpin(cx)); | ||
| let res = n.and_then(|n| match serde_json::from_value::<NotifResponse<Notif>>(n) { |
There was a problem hiding this comment.
does map work here?
I don't mind but clippy doesn't like and_then here...
There was a problem hiding this comment.
Ooh good point! I thought I needed and_then but then didn't realise that I then surrounded all of the result arms in Some :)
niklasad1
approved these changes
Dec 10, 2021
maciejhirsz
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
Streamimpl on theSubscriptiontype, and tweaks the type signatuer of the built-innext()method to be identical (and make it use the Stream impl).Really, the only reason to have a built-in
next()method now is to avoid needing to importStreamExt, but I think that's a perfectly good reason to keep it, and if the type sig is identical it hopefully won't lead to much confusion :)