Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use error(transparent) for wrapped errors when possible #1449

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

niklasad1
Copy link
Member

This changes the jsonrpsee's error to use transparent for wrapped errors for more idiomatic backtraces to avoid print errors etc more than once.

Close #1447

This changes the jsonrpsee's error to use transparent for wrapped errors
for more idiomatic backtraces to avoid print errors etc more than once.
@niklasad1 niklasad1 requested a review from a team as a code owner September 4, 2024 07:31
@niklasad1 niklasad1 changed the title fix: use error(transparent) for errors fix: use error(transparent) for wrapped errors when possible Sep 4, 2024
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@niklasad1 niklasad1 merged commit 792b8fa into master Sep 4, 2024
11 checks passed
@niklasad1 niklasad1 deleted the na-fix-1447 branch September 4, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core::client::Error double prints error message
2 participants