Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code fails when Author information isn't present in the clippings file #25

Closed
rahulakrishna opened this issue May 22, 2021 · 1 comment · Fixed by #26
Closed

Code fails when Author information isn't present in the clippings file #25

rahulakrishna opened this issue May 22, 2021 · 1 comment · Fixed by #26

Comments

@rahulakrishna
Copy link
Contributor

Noticed that some Kindle titles don't have Author information. I faced this issue with "The Intelligent Investor" that I bought from the Kindle Store.

While it doesn't seem possible to fetch the Author info, it can be made so the code gracefully fails and uses an empty string for Author Name. I used a fix locally to get around the issue. Will make a PR later today if this issue is accepted.

Attaching images of clippings file and error message below.

image

image
rahulakrishna added a commit to rahulakrishna/kindle2notion that referenced this issue May 22, 2021
@rahulakrishna
Show error message in case author name is not present
88bdc48 
* Adds a check for author name and shows error message but continues 
execution with empty author name

Resolves: paperboi#25
@rahulakrishna rahulakrishna mentioned this issue May 22, 2021
Merged
@paperboi
Copy link
Owner

Hi @rahulakrishna ! Thanks for raising this issue! Wasn't aware of this particular case with Kindle books. Will merge your changes with the main repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

show error message in case the author_name is not present rahulakrishna/kindle2notion
2 participants
@rahulakrishna @paperboi