Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[messages] replace debug_i2c with debug_vect #179

Merged
merged 1 commit into from
Oct 5, 2023
Merged

[messages] replace debug_i2c with debug_vect #179

merged 1 commit into from
Oct 5, 2023

Conversation

dewagter
Copy link
Member

@dewagter dewagter commented Oct 5, 2023 •
edited
Loading

  • as far as I can find: debug_ir_i2c is not used in any code.
  • debugging vectors aims to be a generic reusable debug message (without needing printf like the standard DEBUG).

@dewagter dewagter mentioned this pull request Oct 5, 2023
Merged
gautierhattenberger
gautierhattenberger approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@gautierhattenberger gautierhattenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remove infrared support a long time ago, IR_SENSORS could be removed as well, next time we need message ID...

@dewagter dewagter merged commit cbb8ad2 into master Oct 5, 2023
@dewagter dewagter deleted the debug_vect branch October 5, 2023 18:48
This was referenced Oct 5, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gautierhattenberger gautierhattenberger gautierhattenberger approved these changes

@fvantienen fvantienen Awaiting requested review from fvantienen

Assignees
No one assigned
Labels
new message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dewagter @gautierhattenberger