[modules] wing-rotation controller with servo #3143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do you enable |
|
You should make |
|
That way the ADC is enabled by itself instead of doing in the airframe |
|
Btw the naming of these defines etc. could be a lot better. Usually it is best to start with the module name, such that they are all grouped together |
fvantienen
previously requested changes
Oct 18, 2023
sw/airborne/modules/rot_wing_drone/wing_rotation_controller_servo.c
Outdated
Show resolved
Hide resolved
sw/airborne/modules/rot_wing_drone/wing_rotation_controller_servo.c
Outdated
Show resolved
Hide resolved
sw/airborne/modules/rot_wing_drone/wing_rotation_controller_servo.h
Outdated
Show resolved
Hide resolved
dewagter
force-pushed
the
wing_rotation_controller
branch
from
351d4b4 to
7aa50f0
Compare
|
@fvantienen update complete |
dewagter
force-pushed
the
wing_rotation_controller
branch
2 times, most recently
from
021b1c6 to
d38bc88
Compare
|
is is still a draft ? |
|
Working on it.
|
update Cleanup rename defines renames cleanup airframe renames remove airspeed Send wing position feedback via ABI (like on the 25kg in AP mode)
dewagter
force-pushed
the
wing_rotation_controller
branch
from
d38bc88 to
6003201
Compare
|
Cleanup complete. |
gautierhattenberger
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.