Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[electrical]: extra ADC #3134

Merged
merged 1 commit into from
Oct 16, 2023
Merged

[electrical]: extra ADC #3134

merged 1 commit into from
Oct 16, 2023

Conversation

dewagter
Copy link
Member

@dewagter dewagter commented Oct 6, 2023

@fvantienen is there a more generic way (to e.g. also add even more in the future)?

@dewagter dewagter mentioned this pull request Oct 6, 2023
Closed
64 tasks
@dewagter dewagter marked this pull request as draft October 6, 2023 20:27
@dewagter dewagter mentioned this pull request Oct 7, 2023
Merged
@dewagter dewagter marked this pull request as ready for review October 7, 2023 13:09
fvantienen
fvantienen approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@fvantienen fvantienen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now

@dewagter dewagter merged commit 2b89019 into master Oct 16, 2023
@dewagter dewagter deleted the extra_adc_cube branch October 16, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fvantienen fvantienen fvantienen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dewagter @fvantienen