Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rpm_actuators] actuators on a bus require indices #3089

Merged
merged 5 commits into from
Sep 22, 2023
Merged

[rpm_actuators] actuators on a bus require indices #3089

merged 5 commits into from
Sep 22, 2023

Conversation

dewagter
Copy link
Member

No description provided.

@dewagter dewagter mentioned this pull request Sep 20, 2023
Merged
4 tasks
@dewagter dewagter marked this pull request as draft September 20, 2023 17:13
dewagter added a commit to tudelft/paparazzi that referenced this pull request Sep 20, 2023
@dewagter
UAVCAN Temp2 ----> paparazzi#3088 and RPM ----> paparazzi#3089
9ecd1b5
@dewagter dewagter mentioned this pull request Sep 20, 2023
Closed
@dewagter dewagter marked this pull request as ready for review September 21, 2023 09:01
@dewagter dewagter mentioned this pull request Sep 21, 2023
Closed
64 tasks
fvantienen
fvantienen previously approved these changes Sep 21, 2023
View reviewed changes
dewagter added a commit to tudelft/paparazzi that referenced this pull request Sep 21, 2023
@dewagter
UAVCAN Temp2 ----> paparazzi#3088 and RPM ----> paparazzi#3089
a5eeb37
@dewagter
Copy link
Member Author

@fvantienen where did SERVOS_DEFAULT_OFFSET come from?

# boards/bebop/actuators.c:146:35: error: ‘SERVOS_DEFAULT_OFFSET’ undeclared (first use in this function)
#   146 |     rpm_message[i].actuator_idx = SERVOS_DEFAULT_OFFSET + i;
#       |                                   ^~~~~~~~~~~~~~~~~~~~~

@fvantienen
Copy link
Member

Did you run make in your main folder? The gen_airframe.ml generates it, that is why you need to run make to compile the ocaml code.

@dewagter dewagter requested a review from fvantienen September 22, 2023 12:09
@dewagter dewagter merged commit 5672d5f into master Sep 22, 2023
@dewagter dewagter deleted the rpm_actuators branch September 22, 2023 12:10
dewagter added a commit that referenced this pull request Sep 23, 2023
@dewagter
[fix] extra for #3089
9541c19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gautierhattenberger gautierhattenberger gautierhattenberger left review comments

@fvantienen fvantienen Awaiting requested review from fvantienen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dewagter @fvantienen @gautierhattenberger