Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use platform-specific directories for virtualenvs #8073

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Use platform-specific directories for virtualenvs #8073

merged 1 commit into from
Aug 29, 2019

Conversation

illicitonion
Copy link
Contributor

This makes it easier to use docker on OSX in-place without having to
delete directories when switching between OSs.

stuhood
stuhood reviewed Jul 19, 2019
View reviewed changes
Copy link
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a buuunch more locations assuming this path, unfortunately:

$ rg '\.venv' | wc -l
18

@illicitonion illicitonion force-pushed the dwagnerhall/platform-specific-virtualenv branch from 5138d60 to b2250eb Compare August 7, 2019 13:03
illicitonion
illicitonion commented Aug 7, 2019
View reviewed changes
Copy link
Contributor Author

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a buuunch more locations assuming this path, unfortunately:

$ rg '\.venv' | wc -l
18

I checked, only one of them actually needs updating; done.

@illicitonion illicitonion force-pushed the dwagnerhall/platform-specific-virtualenv branch from b2250eb to e73145a Compare August 12, 2019 12:42
@illicitonion
Use platform-specific directories for virtualenvs
5d8c420 
This makes it easier to use docker on OSX in-place without having to
delete directories when switching between OSs.
@illicitonion illicitonion force-pushed the dwagnerhall/platform-specific-virtualenv branch from e73145a to 5d8c420 Compare August 28, 2019 17:09
@illicitonion illicitonion merged commit dbf5851 into pantsbuild:master Aug 29, 2019
@illicitonion illicitonion deleted the dwagnerhall/platform-specific-virtualenv branch August 29, 2019 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano left review comments

@stuhood stuhood stuhood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illicitonion @stuhood @Eric-Arellano