Add .vscode/ folder to .gitignore #6020
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
approved these changes
Jun 25, 2018
There was a problem hiding this comment.
We're not doing a great job of this in general, but:
To anchor something to the root of the repository, you should prefix it with /. Would you mind doing that for this one (assuming the .vscode directory will only be created at the root).
We'll do a separate cleanup pass for the other ones.
Changing `.vscode/` to `/.vscode/`
|
Done 👍 |
|
@alanbato independently, it might be a good idea to document how to work on Pants with vscode if you get a chance :) |
kwlzn
approved these changes
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Workspace-specific configuration on Visual Studio Code creates a
.vscode/folder to store thesettings.jsonto store said configuration. Since there were already some editor-specific ignores ingitignore, I figured I might as well include VSCode's.Solution
I added
.vscode/to the.gitignorefile.Result
Now VSCode users won't see a dirty workspace when using project-defined configs :)